[CINN]support backend compiler to link multiple modules #65916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Jul 11, 2024
Comment on lines
+240
to
+243
| if (end) { | ||
| RegisterDeviceModuleSymbol(); | ||
| engine_->AddSelfModule(); | ||
| } |
There was a problem hiding this comment.
这里沿袭了之前扩展x86时候的参数，语义是已经链接完所有的子Module，可以整合起来。
之后PR中会考虑商量修改一下这里的参数命名
tc20042008
reviewed
Jul 11, 2024
| @@ -106,7 +106,7 @@ class Compiler final { | |||
| void Build(const ir::Module& module, | |||
| const std::string& code = "", | |||
| const bool end = true); | |||
| void AppendCX86(const ir::Module& module); | |||
| void AppendCX86(const ir::Module& module, const bool end = true); | |||
There was a problem hiding this comment.
最好不要使用bool值做参数，语义太弱，扩展性太差。
我看这个函数也不大，直接写成两个函数多好啊。就算调用处的就代码已经拿bool值做参数了，也不是新代码继续这么做的理由
Comment on lines
+308
to
+314
| auto PatternMatch = | ||
| adt::match{[&](common::UnknownArch) { CINN_NOT_IMPLEMENTED; }, | ||
| [&](common::X86Arch) { return; }, | ||
| [&](common::ARMArch) { return; }, | ||
| [&](common::NVGPUArch) { RegisterCudaModuleSymbol(); }, | ||
| [&](common::HygonDCUArchHIP) { CINN_NOT_IMPLEMENTED; }}; | ||
| return std::visit(PatternMatch, target_.arch.variant()); |
There was a problem hiding this comment.
改一下代码，让它好看点：
return target_.arch.Match(
[&](common::UnknownArch) { CINN_NOT_IMPLEMENTED; },
[&](common::X86Arch) { return; },
[&](common::ARMArch) { return; },
[&](common::NVGPUArch) { RegisterCudaModuleSymbol(); },
[&](common::HygonDCUArchHIP) { CINN_NOT_IMPLEMENTED; });There was a problem hiding this comment.
收到，将在下一个step的PR修改这里的写法
| return std::visit(PatternMatch, target_.arch.variant()); | ||
| [&](common::NVGPUArch) { CompileCudaModule(module, code); }, | ||
| [&](common::HygonDCUArchHIP) { CompileHipModule(module, code); }}; | ||
| std::visit(PatternMatch, target_.arch.variant()); |
There was a problem hiding this comment.
顺手把这里的代码改成target_.arch.Match(...)的形式。
tc20042008
approved these changes
Jul 11, 2024
phlrain
approved these changes
Jul 11, 2024
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
…#65916) * [CINN]support backend compiler to link multiple modules * change comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
Pcard-67164
This PR adds support for codegen of switch, which is the second step for lowering broadcast tree.
To learn more about the theoretical explanation of lowering broadcast tree in host wrapper function and the step-by-step arrangement for the Pull Request (PR), please refer to the draft PR65604 for details.