[PIR]Fix tests #65911
Merged
[PIR]Fix tests #65911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
python/paddle/tensor/manipulation.py
Outdated
Comment on lines
4438
to
4444
| if convert_dtype(x.dtype) == 'bool' and not x.stop_gradient: | ||
| raise ValueError( | ||
| "When the data type of input 'x' for expand_as is bool, " | ||
| "you must set its stop_gradient to be False by " | ||
| "some_var.stop_gradient = True, supporting " | ||
| "some_var as the input 'x'." | ||
| ) |
There was a problem hiding this comment.
这个检查最好只在pir mode下做，否则会影响动态图性能。
There was a problem hiding this comment.
这个我在CI的时候遇到了，现在是联系了泽宇，他修改了baseline。欢哥是希望不影响动态图的性能吗？
Comment on lines
-68
to
-79
| def TestRuntimeErrorStaticMode(): | ||
| paddle.enable_static() | ||
| input_pd = paddle.to_tensor( | ||
| np.random.random([1, 2]).astype(np.float32) | ||
| ) | ||
| input_pd.grad = paddle.to_tensor( | ||
| np.random.random([1, 2]).astype(np.float32) | ||
| ) | ||
| clip_grad_value_(input_pd, clip_value=1) | ||
| paddle.disable_static() | ||
|
|
||
| self.assertRaises(RuntimeError, TestRuntimeErrorStaticMode) |
There was a problem hiding this comment.
这个老静态图是在尝试验证什么类型的报错？TestRuntimeErrorStaticMode
There was a problem hiding this comment.
这个API是只在动态图下运行的，所以进入api后检测到静态题模式会报runtime error
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
* refine tests * fix op benchmark * fix op benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Not User Facing
Description
pcard-67164
Fix tests