[Typing][B-21] Add type annotations for python/paddle/distribution/multinomial.py
#65844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 9, 2024
| @@ -66,7 +71,7 @@ class Multinomial(distribution.Distribution): | |||
| [3., 3., 4.]]]) | |||
| """ | |||
|
|
|||
| def __init__(self, total_count, probs): | |||
| def __init__(self, total_count: int, probs: Tensor) -> None: | |||
| @@ -142,7 +147,7 @@ def log_prob(self, value): | |||
| + (value * logits).sum(-1) | |||
| ) | |||
|
|
|||
| def sample(self, shape=()): | |||
| def sample(self, shape: tuple[int]) -> Tensor: | |||
There was a problem hiding this comment.
Suggested change
| def sample(self, shape: tuple[int]) -> Tensor: | |
| def sample(self, shape: Iterable[int]) -> Tensor: |
用 Iterable 吧，下面代码用的这个做判断 ～
SigureMo
reviewed
Jul 9, 2024
SigureMo
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
B21