Skip to content

[PIR]fix test_fetch_var test in pir mode #65833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Jul 8, 2024

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

修复test_fetch_var.py在新IR下报错,另外删除了一些冗余代码
在新IR下不支持create_tensor和create_varialble的写法,采用paddle.static.data替换
pcard-67164

Copy link

paddle-bot bot commented Jul 8, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@risemeup1 risemeup1 changed the title fix failed tests in pir mode [PIR]fix test_fetch_var test in pir mode Jul 8, 2024
Copy link
Contributor

@chen2016013 chen2016013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -323,7 +323,7 @@ std::string GetValueName(Value value) {

PADDLE_THROW(phi::errors::InvalidArgument(
"Currently, we can only get name of Value from "
"DataOp/ParameterOp/BlockArgument and ShadowOutputOp."));
"DataOp/ParameterOp/BlockArgument and ShadowOutputOp/SetParameterOp."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还没实现 SetParameterOp Value 对应的 name 获取就不要改了 😂

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit d8ea82e into develop Jul 9, 2024
31 of 32 checks passed
@SigureMo SigureMo deleted the fix_numpy2.x_test_spectral_op branch July 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants