Skip to content

[PIR]fix pir failed tests #65730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 8, 2024
Merged

[PIR]fix pir failed tests #65730

merged 7 commits into from
Jul 8, 2024

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Jul 4, 2024 •
edited
Loading

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

修复8个在新IR模式下失败的单测

  • test_sparse_conv/sum/slice/isnan_op.py:该四个单测之前已经适配新IR，开启FLAGS_enable_pir_api=1后和原来单测中的@compare_legacy_with_pt装饰器冲突，清理掉原来的@compare_legacy_with_pt和@test_with_pir_api即可
  • test_auc_op.py：新IR下，在python端auc中传入的slide_steps参数没有和旧IR统一，切新IR下缺少变量和类型检查，导致actual kernel中memcy过程超过边界报了Semetation fault的错误
  • test_python_operator_overriding.py:单测写法问题，废弃了base.Executor和base.default_main_program这种类似写法，改为paddle.static.xxx，并且paddle.static.create_global_var(name='x', shape=shape, value=0.0, dtype=dtype, persistable=True)改写为paddle.static.data且不应该赋值
  • test_compare_op.py:新IR下不支持value.name的写法

pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 4, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@risemeup1 risemeup1 force-pushed the fix_pir_failed_tests/dev branch from f2347fc to 510f91c Compare July 5, 2024 09:11
wanghuancoder
wanghuancoder reviewed Jul 5, 2024
View reviewed changes
python/paddle/static/nn/metric.py
@@ -260,7 +265,7 @@ def auc(
ins_tag_weight,
curve,
num_thresholds,
slide_steps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥直接改成0，这样slide_steps参数就无效了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和原来的旧IR下append op逻辑对齐的

wanghuancoder
wanghuancoder approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 8e80c94 into develop Jul 8, 2024
@risemeup1 risemeup1 changed the title fix pir failed tests [PIR]fix pir failed tests Jul 8, 2024
@SigureMo SigureMo deleted the fix_pir_failed_tests/dev branch July 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risemeup1 @wanghuancoder