[Inference] fix Predictor support pir model save(.json) #65714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
yuanlehome
reviewed
Jul 4, 2024
Comment on lines
1045
to
1047
| auto is_persistable = | ||
| var.attribute<pir::BoolAttribute>(kAttrIsPersistable); | ||
| if (is_persistable && is_persistable.data()) { |
There was a problem hiding this comment.
parameter op的var一定是persistable
yuanlehome
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
Bug fixes
Description
card-71500
修复了pdmodel保存优化后模型(optimized_.json)的bug(输入维度不匹配)，修复了optimized_json中输入类型为pd_op.feed，sub_scope中找不到输入的var