Skip to content

[SOT] Rename StringifyGuard to StringifiedGuard #65648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jul 2, 2024

PR Category

Execute Infrastructure

PR Types

Not User Facing

Description

StringifyGuard 并不合适,因为应该是字符串化「的」guard 而不是字符串化这个过程,因此修改为 StringifiedGuard,确保语法上是正确的

另外还有一个候选词 stringize,比如在 Python 对于类型提示的字符串化描述相关文档中常用该词(如 Annotations Best Practices),但该词貌似并不常用(至少 ChatGPT 是这么说的……),因此还是选择了 stringify

PCard-66972

Copy link

paddle-bot bot commented Jul 2, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo requested review from zrr1999 and gouzil July 3, 2024 01:01
@SigureMo SigureMo changed the title [SOT] Replace StringifyGuard with StringifiedGuard [SOT] Rename StringifyGuard to StringifiedGuard Jul 3, 2024
@SigureMo SigureMo merged commit 876b630 into PaddlePaddle:develop Jul 3, 2024
@SigureMo SigureMo deleted the sot/fix-typo-stringify-to-stringified branch July 3, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants