[Typing] 修改 core.pyi 及一些示例代码中的类型错误 #65496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megemini
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 26, 2024
python/paddle/base/core.pyi
Outdated
| @@ -26,23 +28,39 @@ class Place: | |||
| def set_place(self, place: Place) -> None: ... | |||
| def xpu_device_id(self) -> int: ... | |||
|
|
|||
| class CPUPlace(Place): ... | |||
| class CPUPlace: ... | |||
There was a problem hiding this comment.
这里不「继承」，也不「实现」的话，怎么保证 CPUPlace() 可以传入 foo(p: Place) 呢？
There was a problem hiding this comment.
咱们有个
PlaceLike: TypeAlias = Union[
"CPUPlace",
"CUDAPlace",
"CUDAPinnedPlace",
"IPUPlace",
"CustomPlace",
"XPUPlace",
str, # some string like "cpu", "gpu:0", etc.
]是不是应该用这个？
There was a problem hiding this comment.
不知道 ... ... 可能有地方单独需要 Place 的一些方法？
class Place(Protocol):
def custom_device_id(self) -> int: ...
def custom_device_type(self) -> str: ...
def gpu_device_id(self) -> int: ...
def ipu_device_id(self) -> int: ...
def is_cpu_place(self) -> bool: ...
def is_cuda_pinned_place(self) -> bool: ...
def is_custom_place(self) -> bool: ...
def is_gpu_place(self) -> bool: ...
def is_ipu_place(self) -> bool: ...
def is_xpu_place(self) -> bool: ...
def set_place(self, place: Place) -> None: ...
def xpu_device_id(self) -> int: ...There was a problem hiding this comment.
所以为啥不实现呢？
所有 Place 实现这个 Place 不可以么？
然后我们是不是可以用 PlaceLike: TypeAlias = Union[Place, str]？
Update 20240626
|
SigureMo
reviewed
Jun 26, 2024
| @@ -54,7 +54,7 @@ def __init__( | |||
| oup: int, | |||
| stride: int, | |||
| expand_ratio: float, | |||
| norm_layer: nn.Layer = nn.BatchNorm2D, | |||
| norm_layer: type[nn.Layer] = nn.BatchNorm2D, | |||
There was a problem hiding this comment.
哦？好像当时还只看到 mobilenetv3 ～ 我撤掉就行 ～
Update 20240627
|
喔喔，还有点问题 |
居然影响到这里 ... ... 防不胜防 ～～～ |
SigureMo
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
core.pyi中XXXPlace不再继承Placecore.pyi一些类及方法关联 PR #65008 #65397
@SigureMo