Skip to content

[Typing][A-37,A-38] Add type annotations for paddle/optimizer/{adadelta,adagrad}.py #65464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

ooooo-create
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • paddle/optimizer/adadelta.py
  • paddle/optimizer/adagrad.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jun 25, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 25, 2024
@SigureMo SigureMo changed the title [Typing][A-37,A-38] Add type annotations for paddle/optimizer/(adadelta.py,adagrad.py) [Typing][A-37,A-38] Add type annotations for paddle/optimizer/{adadelta,adagrad}.py Jun 25, 2024
SigureMo
SigureMo previously approved these changes Jun 25, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2024
@SigureMo
Copy link
Member

doc preview 怎么挂了呢?rerun 过还是挂了

@ooooo-create
Copy link
Contributor Author

doc preview 怎么挂了呢?rerun 过还是挂了

是格式错误吗

************************************************************************************
2024-06-26 11:03:30 Your PR code style check failed.
2024-06-26 11:03:30 Please install pre-commit locally and set up git hook scripts:
2024-06-26 11:03:30 
2024-06-26 11:03:30     pip install pre-commit==2.17.0
2024-06-26 11:03:30     pre-commit install
2024-06-26 11:03:30 
2024-06-26 11:03:30 Then, run pre-commit to check codestyle issues in your PR:
2024-06-26 11:03:30 
2024-06-26 11:03:30     pre-commit run --files
2024-06-26 11:03:30 
2024-06-26 11:03:30 For more information, please refer to our codestyle check guide:
2024-06-26 11:03:30 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/codestyle_check_guide_cn.html

@ooooo-create
Copy link
Contributor Author

ooooo-create commented Jun 26, 2024

不是 git 仓库 好像是

Checking code style by pre-commit ...
2024-06-26 11:03:30 An error has occurred: FatalError: git failed. Is it installed, and are you in a Git repository directory?

@SigureMo SigureMo merged commit 32f7c5c into PaddlePaddle:develop Jun 27, 2024
@ooooo-create ooooo-create deleted the typing/37-38 branch June 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants