Skip to content

[XPU] fix flash_attn_unpadded on kl2 #65418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Jun 24, 2024

PR Category

Custom Device

PR Types

Bug fixes

Description

在之前的 #65221 中,错误地将FlashAttnUnpaddedKernel也包在了PADDLE_WITH_XPU_XRE5宏定义里面,导致在KL2下面这个算子会被跳过。本PR修复了此问题。

感谢 @runzhech 指出。

Copy link

paddle-bot bot commented Jun 24, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@runzhech runzhech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 closed this Jun 25, 2024
@houj04 houj04 reopened this Jun 25, 2024
Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZibinGuo ZibinGuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen QingshuChen merged commit 72cb05e into PaddlePaddle:develop Jun 25, 2024
@ZibinGuo
Copy link
Contributor

ZibinGuo commented Jun 25, 2024 via email

co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
@houj04 houj04 added the XPU label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants