[DCU] fix fused_bias_act op #65399
Merged
[DCU] fix fused_bias_act op #65399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
PR-CI-Hygon-DCU-Test失败单测中不包含 |
qili93
reviewed
Jun 25, 2024
|
@qili93 已按照review修改，PR-CI-Hygon-DCU-Test失败原因非本算子单测 |
qili93
reviewed
Jun 26, 2024
| @@ -94,7 +94,8 @@ def fused_act_bias_wrapper( | |||
|
|
|||
|
|
|||
| @unittest.skipIf( | |||
| not core.is_compiled_with_cuda(), "core is not compiled with CUDA" | |||
| not core.is_compiled_with_cuda() and not core.is_compiled_with_rocm(), | |||
| "core is not compiled with CUDA or ROCm", | |||
There was a problem hiding this comment.
这里可以不用修改，你可以看下 is_compiled_with_cuda 的实现，当初了为支持HIP和CUDA的兼容，当编译的时候是HIP的时候，也会返回True，可以参考
Paddle/paddle/fluid/pybind/pybind.cc
Line 265 in 9eb5b03
下面几行也是一样。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description
card-84892
fix fused_bias_act_utils on DCU
fix load_store_util on DCU