Skip to content

Add cmake argument to set ninja compilation job pools for flash attention. #65339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

umiswing
Copy link
Member

@umiswing umiswing commented Jun 20, 2024

PR Category

Others

PR Types

Devs

Description

新增cmake参数FA_JOB_POOLS_COMPILE,用以控制ninja编译flash attention时最大job数量。

Copy link

paddle-bot bot commented Jun 20, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 20, 2024
Copy link

paddle-ci-bot bot commented Jun 28, 2024

Sorry to inform you that 7fe2a91's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@umiswing umiswing marked this pull request as draft July 4, 2024 06:56
@umiswing umiswing marked this pull request as ready for review July 4, 2024 06:56
@umiswing umiswing changed the title [WIP] Increase job pools when compiling flash attention. Add cmake argument to set ninja compilation job pools for flash attention. Jul 5, 2024
Copy link
Collaborator

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuoxiaWang GuoxiaWang merged commit de8b7b6 into PaddlePaddle:develop Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants