[CINN]Fix ReshapeOpInferSymbolicShape while target_shape contains 0 #65185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
commented
Jun 17, 2024
| const auto &target_shape = [&] { | ||
| std::vector<symbol::DimExpr> target_shape; | ||
| for (size_t i = 0; i < shape.size(); ++i) { | ||
| if (shape[i] == 0) { |
There was a problem hiding this comment.
对于target_shape=0 的场景，应该使用输入X对应的dim expr，而不是使用0。否则 line 182 行会出现除0的操作。
plush: line 183行的 out_dim_expr = IsZero(target_shape[i]) ? original_shape[i] : out_dim_expr; 应该可以删除，若有其他comment，则一并fix；若无，则单独PR 删除
zyfncg
approved these changes
Jun 17, 2024
tc20042008
approved these changes
Jun 17, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-67164