Skip to content

[XPU] support ignore_index in c_softmax_with_cross_entropy #65149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Jun 13, 2024

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

#64543 类似,给XPU下面的c_softmax_with_cross_entropy算子添加对ignore_index的支持。之前的版本会完全忽略这个参数,导致计算错误。

单测:在 #65613 中,修改了单测进程之间交互数据的方式,从走管道变成了走临时文件。本PR跟着进行了修改。

Copy link

paddle-bot bot commented Jun 13, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-ci-bot bot commented Jun 21, 2024

Sorry to inform you that 7709ec7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@runzhech runzhech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lj970926 lj970926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen QingshuChen merged commit 3dbb7bc into PaddlePaddle:develop Jul 11, 2024
30 of 32 checks passed
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Jul 22, 2024
…dle#65149)

* [XPU] support ignore_index in c_softmax_with_cross_entropy

* refactor: add new FixLossAccordingToIgnoreIndex function.

* fix ut.
@houj04 houj04 added the XPU label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants