Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pybind] update py::exception<>::operator() to py::set_error #63805

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Apr 24, 2024

PR Category

Others

PR Types

Bug fixes

Description

在 pybind 2.12 中,py::exception<>::operator()已经被标记为弃用,使用py::set_error()代替

相关链接:

Copy link

paddle-bot bot commented Apr 24, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 24, 2024
@gouzil gouzil closed this Apr 24, 2024
@gouzil gouzil reopened this Apr 24, 2024
@gouzil gouzil changed the title [WIP][pybind] fix BindException [WIP][pybind] update py::exception<> to py::set_error Apr 24, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 24, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 24, 2024
@gouzil gouzil changed the title [WIP][pybind] update py::exception<> to py::set_error [pybind] update py::exception<> to py::set_error Apr 24, 2024
@SigureMo SigureMo changed the title [pybind] update py::exception<> to py::set_error [pybind] update py::exception<>::operator() to py::set_error Apr 24, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo closed this Apr 24, 2024
@SigureMo SigureMo reopened this Apr 24, 2024
@gouzil gouzil merged commit 71fd732 into PaddlePaddle:develop Apr 24, 2024
28 of 30 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 25, 2024
@lizexu123
Copy link
Contributor

7f31d91713e747f93e9c2e7ebc7dc7da 这个怎么改呢,删除了源码下third_party/pybind,然后git submodule update --init,make clean,还是复现这个错误

@gouzil
Copy link
Member Author

gouzil commented Jun 25, 2024

这个怎么改呢,删除了源码下third_party/pybind,然后git submodule update --init,make clean,还是复现这个错误

提个 issue, 把详细的配置环境、系统版本、cmake指令全部贴上。 可以顺便贴一下 pybind 的 commit 看看是多少

@gouzil gouzil deleted the fix_pybind_BindException branch November 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants