[PIR+CINN]Consider ShapeAnalysis SymDimExprs instead of sym_expr_str attribute as Hash element #63636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
changed the title
Aurelius84
commented
Apr 19, 2024
| void FusionOpAnalysis::PreCompileGroup() { | ||
| // Make compilation into lazy mode while | ||
| // FLAGS_enable_cinn_compile_cache=false. | ||
| if (!FLAGS_enable_cinn_compile_cache) return; |
Contributor
Author
There was a problem hiding this comment.
为什么要跳过这里？
之前设置FLAGS_enable_compile_cache=false依然可能有问题，是因为关闭缓存策略时，编译的操作也是在PreAnalysis阶段，但从PreAnanlysis阶段到FusionOpPattern里的JitKernel替换这中间（如Lowering等），虽然传递的是const OpLoweringGroupPtr&，但shared_ptr的-> 依然可以改变group的内在状态，导致后面从缓存Get时，计算出来的HashKey不一样，会报错，
tc20042008
approved these changes
Apr 19, 2024
zhangbo9674
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Not User Facing
Description
Pcard-67164
Program里的sym_expr_str里的符号信息现在没有友好地维护和更新，应该统一使用ShapeAnalysis里的符号作为FusionInfo的符号信息