-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Compile cblas library as static #6347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hi, @Yancey1989 MKLML do not have static lib yet, maybe you can not directly change it. |
@tensor-tang I think it is OK. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tensor-tang @luotao1 Please check it again.
I do not think CI can test this case, like the #6309 is not tested. Have you ever tried locally after this change? |
If it is really what you said just recording the dependency, then why changing this to static can help the issue #6309 since MKLML do not have static. And I found this code is change from this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the way to solve the issue is to link the mklml.so with cblas.so, not directly change it to static.
Hi @tensor-tang
Yes, it passed the test.
the cblas library is just a wrapper, and built from and the cblas will depend MKL if |
I have tried locally. The mkl.so is contained in the so, so the cblas.a would not bother now. |
Fixed #6309