Skip to content

Change the type of conv2d in Python API. #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2017
Merged

Change the type of conv2d in Python API. #6336

merged 1 commit into from
Dec 6, 2017

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Dec 6, 2017 •
edited
Loading

Before the cuDNN is exposed to Python API, change the type of conv2d temporarily.

jacquesqiao
jacquesqiao approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

reyoung
reyoung requested changes Dec 6, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cannot be merged since it will break CPU code.

reyoung
reyoung approved these changes Dec 6, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake

@qingqing01 qingqing01 merged commit 429d67d into PaddlePaddle:develop Dec 6, 2017
@qingqing01 qingqing01 deleted the cudnn_conv_op branch November 14, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingqing01 @reyoung @jacquesqiao