[Dynamic shape] Add HasShapeOrDataForValue code for shapeAnalysis #60644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
This was referenced Jan 9, 2024
zhangbopd
force-pushed
the
clean
branch
2 times, most recently
from
d1a4fe4 to
ee57e81
Compare
zhangbopd
force-pushed
the
clean
branch
2 times, most recently
from
ee57e81 to
5ad04bd
Compare
zhangbopd
changed the title
jiahy0825
reviewed
Jan 16, 2024
Comment on lines
-153
to
-154
| // TODO(lanxianghit): check this when all the Ops support InferSymbolicShape | ||
| // CHECK(value_to_shape_or_data_.find(val) != value_to_shape_or_data_.end()); |
There was a problem hiding this comment.
后续有在 Get 接口里添加 CHECK 的计划吗？这个 TODO 是否需要去掉？
There was a problem hiding this comment.
我理解这里提供接口后，不需要 Get 接口里添加 CHECK 了，我同步给lanxianghit确认一下~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
提供 HasShapeOrDataForValue 接口