Skip to content

Conversation

@gitliuyf
Copy link
Contributor

@gitliuyf gitliuyf commented Dec 1, 2023

PR types

Bug fixes

PR changes

Others

Description

bug fixes:when two cast is float->bool + bool->float, forbid delete funciton.

@gitliuyf gitliuyf force-pushed the develop branch 2 times, most recently from 6190ecc to eb71db5 Compare December 1, 2023 07:15
Copy link
Contributor

@csy0225 csy0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XPUKernelSet({phi::DataType::INT32,
phi::DataType::INT64,
phi::DataType::FLOAT32})},
{"fast_where_xpu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不确定 plugin kernel 是否适用于昆仑一

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

option(WITH_XPU_PLUGIN "Compile PaddlePaddle with BAIDU XPU plugin" OFF)
plugin默认是关的

XPUKernelSet({phi::DataType::FLOAT32,
phi::DataType::INT32,
phi::DataType::INT64})},
{"add_layernorm_xpu", XPUKernelSet({phi::DataType::FLOAT32})},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 plugin kernel 可能也不适用于 昆仑一

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不是plugin的kernel

Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot paddle-bot bot added the contributor External developers label Dec 1, 2023
@hong19860320 hong19860320 merged commit 78534d8 into PaddlePaddle:develop Dec 4, 2023
SigureMo pushed a commit to gouzil/Paddle that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants