-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[xpu] register fast_where and forbid pass if remove cast bool;test=develop #59594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6190ecc to
eb71db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| XPUKernelSet({phi::DataType::INT32, | ||
| phi::DataType::INT64, | ||
| phi::DataType::FLOAT32})}, | ||
| {"fast_where_xpu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不确定 plugin kernel 是否适用于昆仑一
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
option(WITH_XPU_PLUGIN "Compile PaddlePaddle with BAIDU XPU plugin" OFF)
plugin默认是关的
| XPUKernelSet({phi::DataType::FLOAT32, | ||
| phi::DataType::INT32, | ||
| phi::DataType::INT64})}, | ||
| {"add_layernorm_xpu", XPUKernelSet({phi::DataType::FLOAT32})}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 plugin kernel 可能也不适用于 昆仑一
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不是plugin的kernel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Paddle#59594) Co-authored-by: newway <liuwei345@gmail.com>
PR types
Bug fixes
PR changes
Others
Description
bug fixes:when two cast is float->bool + bool->float, forbid delete funciton.