Skip to content

Conversation

@tianshuo78520a
Copy link
Collaborator

@tianshuo78520a tianshuo78520a commented Nov 30, 2023

PR types

Others

PR changes

Others

Description

CUDA12 单测失败,临时禁用单测
Pcard-67012


endif()

if(WITH_COVERAGE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该把在这个之前加一下判断条件
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

add_subdirectory(multinode)

if(WITH_COVERAGE)
list(REMOVE_ITEM TEST_OPS test_collective_reduce_scatter_api)
Copy link
Contributor

@XieYunshen XieYunshen Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断条件里面加一个NOT WITH_COVERAGE
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

XieYunshen
XieYunshen previously approved these changes Dec 1, 2023
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit da1f7d0 into PaddlePaddle:develop Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants