[PIR] support attach interface for OpInfo. #59369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
winter-wang
force-pushed
the
cf_develop
branch
8 times, most recently
from
5a33c1c to
5ef4bfa
Compare
winter-wang
force-pushed
the
cf_develop
branch
from
5ef4bfa to
75a38a0
Compare
zhangbo9674
approved these changes
Nov 27, 2023
| const std::vector<std::vector<pir::OpResult>> &outputs, | ||
| const std::vector<std::vector<pir::Value>> &out_grads, | ||
| const std::vector<std::vector<bool>> &stop_gradients) { | ||
| PADDLE_ENFORCE_EQ(inputs.size() == 1u && inputs[0].size() >= 1u, |
There was a problem hiding this comment.
我觉得判断一下比较好，不然后面inputs[0][0]可能会直接崩溃，不好发现原因
| (void)std::initializer_list<int>{ | ||
| 0, (PlacementConstrctInterface<Args>(p_interface), 0)...}; | ||
| return p_interface; | ||
| 0, (PlacementConstrctInterface<Args>(interface_set), 0)...}; |
There was a problem hiding this comment.
Suggested change
| 0, (PlacementConstrctInterface<Args>(interface_set), 0)...}; | |
| 0, (ConstrctInterface<Args>(interface_set), 0)...}; |
There was a problem hiding this comment.
好的，这个名字我在下个pr中修改。
| const char **p_attributes, | ||
| VerifyPtr verify_sig, | ||
| VerifyPtr verify_region) | ||
| : interface_set_(std::move(interface_set)), |
There was a problem hiding this comment.
将interface_set_调整到num_traits后面或前面会更好？
There was a problem hiding this comment.
个人觉得占用空间最大的成员变量放在最前面会比较好。我们可以再讨论一下。
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Other
Pcard-67164