Skip to content

Conversation

@zhiheng-liu
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

在clang-tidy.py文件中,检测命令的参数“--version”需要通过一个数组元素单独提供,否则会导致Windows下的检测失败。
将原有代码:

out = subprocess.check_output(['clang-tidy --version'], shell=True)

修改为:

out = subprocess.check_output(['clang-tidy', '--version'], shell=True)

后检测成功。

@paddle-bot
Copy link

paddle-bot bot commented Nov 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 19, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 20, 2023
@luotao1
Copy link
Contributor

luotao1 commented Nov 20, 2023

@GreatV 可以给个approve😄

Copy link
Contributor

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 6e6f9ef into PaddlePaddle:develop Nov 20, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants