【PIR】modify backward for controlflow op #59020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
approved these changes
Nov 16, 2023
| if op don't has grad_op, if it don't has input and it's output has more than | ||
| one output_grad, add sumop for grad aggregation. | ||
| if op don't has grad_op: | ||
| if it don't has input and it's output has more than |
There was a problem hiding this comment.
Suggested change
| if it don't has input and it's output has more than | |
| if it doesn't has input and its output has more than |
后续PR可以连带修改下
|
|
||
| def append_backward_ops( | ||
| block, effective_forward_ops, no_grad_set, backward_ops, state | ||
| fwd_block, |
There was a problem hiding this comment.
控制流分支会用到，现在还缺接口该分支未实现
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* add refresh stopgradint * add refresh stopgradint * modofy * modify backward * modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Description
pcard-67164
修改backward部分逻辑以适配控制流反向