Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][Fix System Message No.4、5、6、8] #58626

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

huajiao-hjyp
Copy link
Contributor

PR types

Bug fixes

PR changes

Docs

Description

Docathon 英文文档格式修复

Copy link

paddle-bot bot commented Nov 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 2, 2023
>>> import paddle.distributed.fleet as fleet
>>> role = fleet.PaddleCloudRoleMaker()
>>> fleet.init(role)


.. code-block:: python
:name: code-example4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然上面改了,这也一并改了吧

Suggested change
:name: code-example4
:name: code-init-example4

>>> import paddle.distributed.fleet as fleet
>>> strategy = fleet.DistributedStrategy()
>>> fleet.init(strategy=strategy)


.. code-block:: python
:name: code-example5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:name: code-example5
:name: code-init-example5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle/device 下的文档已经在 #58508 都顺手统一改了~这边就不用改了

log_level (Integer, String, optional): A ``Integer`` or ``String`` Variable determining how hight
the logging level is. Default is "INFO".

log_level (Integer, String, optional): A ``Integer`` or ``String`` Variable determining how hight the logging level is. Default is "INFO".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边原来的写法好像是没问题的?

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
Copy link

paddle-ci-bot bot commented Nov 10, 2023

Sorry to inform you that fa4470f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1
Copy link
Contributor

luotao1 commented Nov 16, 2023

@Tomoko-hjf 子任务7已经合入了

@huajiao-hjyp huajiao-hjyp changed the title [Docathon][Fix System Message No.4-8] [Docathon][Fix System Message No.4、5、6、8] Nov 16, 2023
@huajiao-hjyp
Copy link
Contributor Author

huajiao-hjyp commented Nov 16, 2023

@Tomoko-hjf 子任务7已经合入了

@luotao1 好的,任务7相关的device文档撤回修改了,修改了下PR标题,剩余的题目有PR了吗,有的话我close掉这个PR

@luotao1
Copy link
Contributor

luotao1 commented Nov 16, 2023

剩余的题目目前还没看到PR

@huajiao-hjyp
Copy link
Contributor Author

@sunzhongkai588 请问最后的这个CI是不是需要approve下才可以通过呢~
image

@luotao1
Copy link
Contributor

luotao1 commented Nov 16, 2023

对的,等孙师傅review就行

Copy link

paddle-ci-bot bot commented Nov 23, 2023

Sorry to inform you that 3c86979's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 23, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 23, 2023
@luotao1 luotao1 merged commit dbfe8b8 into PaddlePaddle:develop Nov 23, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants