Skip to content

Conversation

@0x45f
Copy link
Contributor

@0x45f 0x45f commented Oct 19, 2023

PR types

Others

PR changes

Others

Description

[PIR]Migrate isclose into pir

  • 除了error类的,其他测试case都已经打开了

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Oct 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@0x45f
Copy link
Contributor Author

0x45f commented Oct 24, 2023

将isclose的yaml配置修改为Scalar(double)会影响opmaker的生成,所以修改了opmaker生成的相关代码

YuanRisheng
YuanRisheng previously approved these changes Oct 25, 2023
place = paddle.CUDAPlace(0)
exe = paddle.static.Executor(place)
exe.run(paddle.static.default_startup_program())
exe.run(startup)
Copy link
Contributor

@zyfncg zyfncg Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成double类型有没有验证超过float32范围的数值精度?

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 383a62d into PaddlePaddle:develop Oct 30, 2023
@0x45f 0x45f deleted the pir-isclose branch October 30, 2023 08:07
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants