Skip to content

Conversation

@LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Oct 12, 2023

PR types

Performance optimization

PR changes

Others

Description

Pcard-73145

优化拷贝性能,将DistTensor里存放的DenseTensor由对象改为指针。

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DistTensor::DistTensor(const phi::DenseTensor& global_value,
DistTensor::DistTensor() : value_(std::make_shared<DenseTensor>()) {}

DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DenseTensor初始化DistTensor,给的DenseTensor一定要是global的吗?

@LiYuRio LiYuRio merged commit 8ed7c41 into PaddlePaddle:develop Oct 13, 2023
@LiYuRio LiYuRio deleted the dev_dist_tensor branch October 13, 2023 06:22
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants