Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.51】 为 Paddle 新增 flatten 的 spmd 切分推导规则 #57875

Merged
merged 9 commits into from
Oct 17, 2023
203 changes: 203 additions & 0 deletions paddle/phi/infermeta/spmd_rules/flatten.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
/* Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License. */

#include "paddle/phi/infermeta/spmd_rules/flatten.h"
#include <numeric>

#include "glog/logging.h"

#include "paddle/phi/core/distributed/auto_parallel/dist_attr.h"
#include "paddle/phi/core/distributed/auto_parallel/inferspmd_utils.h"
#include "paddle/phi/core/distributed/auto_parallel/utils.h"
#include "paddle/phi/infermeta/spmd_rules/dim_trans.h"
#include "paddle/phi/infermeta/spmd_rules/utils.h"

namespace phi {
namespace distributed {

using phi::distributed::auto_parallel::str_join;

int PreprocessAxis(int axis, int ndim) {
if (axis < 0) {
axis += ndim;
}

PADDLE_ENFORCE_LT(
axis,
ndim,
phi::errors::InvalidArgument("The Start_axis or Stop_axis [%d] is not "
"less than the Tensor X's rank [%d].",
axis,
ndim));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api里没有约定axis超过ndim时取最后一维,不要这么操作,可以直接报错

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return axis;
}

std::vector<DimTrans*> MakeFlattenDimTrans(
const std::vector<int64_t>& src_shape, int start_axis, int stop_axis) {
std::vector<DimTrans*> ret;

std::vector<DimTrans*> input_dims;
for (int64_t i = 0; i < static_cast<int64_t>(src_shape.size()); i++) {
if (i < start_axis || i > stop_axis) {
ret.emplace_back(new InputDim(i));
} else {
input_dims.emplace_back(new InputDim(i));
}

if (i == stop_axis) {
ret.emplace_back(make_flatten(input_dims));
}
}

return ret;
}

std::vector<DimTrans*> MakeFlattenDimTransReverse(
const std::vector<int64_t>& src_shape, int start_axis, int stop_axis) {
std::vector<DimTrans*> ret;

std::vector<int64_t> tgt_splitted_shape;
for (int i = start_axis; i <= stop_axis; i++) {
tgt_splitted_shape.emplace_back(src_shape[i]);
}

for (int64_t i = 0; i < static_cast<int64_t>(src_shape.size()); i++) {
if (i < start_axis) {
ret.emplace_back(new InputDim(i));
} else if (i > stop_axis) {
ret.emplace_back(new InputDim(i - (stop_axis - start_axis)));
} else {
ret.emplace_back(make_split(
new InputDim(start_axis), tgt_splitted_shape, i - start_axis));
}
}

return ret;
}

SpmdInfo FlattenInferSpmd(const DistMetaTensor& x,
int start_axis,
int stop_axis) {
// Step0: Verify input args based on flatten logic
auto src_shape = phi::vectorize(x.dims());
int x_ndim = static_cast<int64_t>(src_shape.size());
auto x_dist_attr_src = x.dist_attr();
std::vector<int64_t> x_dims_mapping = x_dist_attr_src.dims_mapping();
PADDLE_ENFORCE_EQ(
x_ndim,
x_dims_mapping.size(),
phi::errors::InvalidArgument("The Tensor X's rank [%d] and X's "
"dims_mapping size [%d] are not matched.",
x_ndim,
x_dims_mapping.size()));

// Step1: Build the transformation from
// the original shape to the target shape

start_axis = PreprocessAxis(start_axis, x_ndim);
stop_axis = PreprocessAxis(stop_axis, x_ndim);
std::vector<DimTrans*> trans =
MakeFlattenDimTrans(src_shape, start_axis, stop_axis);

// Step2: Infer the dims mapping of input (if reshard is
// needed) and output from the dimension transformation.
std::vector<std::vector<int64_t>> dims_mapping_vec =
InferFromDimTrans(x, trans);

// Step3: Update the dist attributes of input
// and output with the inferred dims mapping.
TensorDistAttr x_dist_attr_dst(x_dist_attr_src);
x_dist_attr_dst.set_dims_mapping(dims_mapping_vec[0]);
TensorDistAttr out_dist_attr(x_dist_attr_src);
out_dist_attr.set_dims_mapping(dims_mapping_vec[1]);

VLOG(4) << "FlattenInferSpmd: X shape: [" << str_join(src_shape) << "]";
VLOG(4) << "Start_axis: " << start_axis;
VLOG(4) << "Stop_axis: " << start_axis;
VLOG(4) << "Transformation from input to output:";
for (int64_t i = 0, n = static_cast<int64_t>(trans.size()); i < n; i++) {
DimTrans* t = trans[i];
VLOG(4) << "\tOut axis[" << i << "]: " << t->to_string();
}
VLOG(4) << "X dims_mapping_src: [" << str_join(x_dims_mapping)
<< "] dims_mapping_dst: [" << str_join(dims_mapping_vec[0]) << "]";
VLOG(4) << "Out dims_mapping: [" << str_join(dims_mapping_vec[1]) << "]\n\n";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把 Out 的输出另用一个VLOG,这样看起来清楚,跑单测的时候输出调试信息看一下:
VLOG(4) << "X dims_mapping_src: [" << str_join(x_dims_mapping)
<< "] dims_mapping_dst: [" << str_join(dims_mapping_vec[0]) << "]";
VLOG(4) << "Out dims_mapping: [" << str_join(dims_mapping_vec[1]) << "]\n\n";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CleanUp();

return {{x_dist_attr_dst}, {out_dist_attr}};
}

SpmdInfo FlattenInferSpmdReverse(const DistMetaTensor& x,
const DistMetaTensor& out,
int start_axis,
int stop_axis) {
// Step0: Verify input args based on flatten logic
auto x_shape = phi::vectorize(x.dims());
auto x_ndim = x_shape.size();
auto out_shape = phi::vectorize(out.dims());
int out_ndim = out_shape.size();
auto out_dist_attr_src = out.dist_attr();
std::vector<int64_t> out_dims_mapping = out_dist_attr_src.dims_mapping();
PADDLE_ENFORCE_EQ(
out_ndim,
out_dims_mapping.size(),
phi::errors::InvalidArgument("The Tensor Out's rank [%d] and Out's "
"dims_mapping size [%d] are not matched.",
out_ndim,
out_dims_mapping.size()));

// Step1: Build the transformation from the output shape
// to original shape. This function infers the dims mapping
// from output to input, we first get the transformation
// from output to input so that we can infer the dims mapping
// with the map from output axes to input axes.

start_axis = PreprocessAxis(start_axis, x_ndim);
stop_axis = PreprocessAxis(stop_axis, x_ndim);

std::vector<DimTrans*> trans =
MakeFlattenDimTransReverse(x_shape, start_axis, stop_axis);

// Step2: Infer the dims mapping of input with
// output's dims_mapping and the transformation.
std::vector<std::vector<int64_t>> dims_mapping_vec =
InferFromDimTrans(out, trans);

// Step3: Update the dist attributes of input
// and output with the inferred dims mapping
TensorDistAttr out_dist_attr_dst(out_dist_attr_src);
out_dist_attr_dst.set_dims_mapping(dims_mapping_vec[0]);
TensorDistAttr x_dist_attr(x.dist_attr());
x_dist_attr.set_dims_mapping(dims_mapping_vec[1]);

VLOG(4) << "FlattenInferSpmdReverse: Out shape: [" << str_join(out_shape)
<< "] X shape: [" << str_join(x_shape) << "]";
VLOG(4) << "Transformation from output to input:";
for (int64_t i = 0, n = trans.size(); i < n; i++) {
DimTrans* t = trans[i];
VLOG(4) << "\tX axis[" << i << "]: " << t->to_string();
}
VLOG(4) << "Out dims_mapping_src: [" << str_join(out_dims_mapping) << "] "
<< "dims_mapping_dst: [" << str_join(dims_mapping_vec[0]) << "]";
VLOG(4) << "X dims_mapping: [" << str_join(dims_mapping_vec[1]) << "]\n\n";

CleanUp();

return {{x_dist_attr}, {out_dist_attr_dst}};
}

} // namespace distributed
} // namespace phi
34 changes: 34 additions & 0 deletions paddle/phi/infermeta/spmd_rules/flatten.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/* Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License. */

#pragma once

#include <vector>

#include "paddle/phi/core/distributed/auto_parallel/dist_meta_tensor.h"
#include "paddle/phi/core/distributed/type_defs.h"

namespace phi {
namespace distributed {

SpmdInfo FlattenInferSpmd(const DistMetaTensor& x,
int start_axis,
int stop_axis);

SpmdInfo FlattenInferSpmdReverse(const DistMetaTensor& x,
const DistMetaTensor& out,
int start_axis,
int stop_axis);
} // namespace distributed
} // namespace phi
6 changes: 6 additions & 0 deletions paddle/phi/infermeta/spmd_rules/rules.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ limitations under the License. */
#include "paddle/phi/infermeta/spmd_rules/default_data_parallel.h"
#include "paddle/phi/infermeta/spmd_rules/elementwise.h"
#include "paddle/phi/infermeta/spmd_rules/embedding.h"
#include "paddle/phi/infermeta/spmd_rules/flatten.h"
#include "paddle/phi/infermeta/spmd_rules/layer_norm.h"
#include "paddle/phi/infermeta/spmd_rules/matmul.h"
#include "paddle/phi/infermeta/spmd_rules/reduction.h"
Expand Down Expand Up @@ -492,6 +493,11 @@ PD_REGISTER_SPMD_RULE(reshape2,
PD_INFER_SPMD(phi::distributed::ReshapeInferSpmd),
PD_INFER_SPMD(phi::distributed::ReshapeInferSpmdReverse));

// flatten rule
PD_REGISTER_SPMD_RULE(flatten,
PD_INFER_SPMD(phi::distributed::FlattenInferSpmd),
PD_INFER_SPMD(phi::distributed::FlattenInferSpmdReverse));

// embedding rule
PD_REGISTER_SPMD_RULE(
embedding,
Expand Down
1 change: 1 addition & 0 deletions test/auto_parallel/spmd_rules/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ if(WITH_DISTRIBUTE)
py_test_modules(test_default_data_parallel_rule MODULES
test_default_data_parallel_rule)
py_test_modules(test_layer_norm_rule MODULES test_layer_norm_rule)
py_test_modules(test_flatten_rule MODULES test_flatten_rule)
# End of unittests WITH single card WITHOUT timeout

endif()
Loading