Skip to content

Conversation

@chengduoZH
Copy link
Contributor

        if num_channels % groups is not 0:
            raise ValueError("num_channels must be divisible by groups.")
        num_filter_channels = num_channels / groups

This expression( if num_channels % groups is not 0) is wrong, it should be if num_channels % groups != 0

@chengduoZH chengduoZH requested a review from JiayiFeng November 20, 2017 05:26
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit 9db4d01 into PaddlePaddle:develop Nov 20, 2017
@chengduoZH chengduoZH deleted the fix_layer.py.conv2dbug branch January 29, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants