Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon] Fix NO.51-64 API Label #57606

Closed
wants to merge 13 commits into from
Closed

[Docathon] Fix NO.51-64 API Label #57606

wants to merge 13 commits into from

Conversation

Sekiro-x
Copy link
Contributor

@Sekiro-x Sekiro-x commented Sep 21, 2023

PR types

Others

PR changes

Docs

Description

api_nn_pooling_MaxPool3d修改为api_paddle_nn_MaxPool3D

api_nn_pooling_MaxUnPool2D修改为api¬¬_paddle_nn_MaxUnPool2D
api_nn_vision_ChannelShuffle修改为api_paddle_nn_ChannelShuffle
api_sparse_pooling_MaxPool3d修改为api_paddle_sparse_nn_MaxPool3D
api_static_nn_concat修改为api_paddle_static_nn_sequence_concat
api_static_nn_pool2d修改为api_paddle_static_nn_sequence_pool
api_static_nn_reshape 修改为api_paddle_static_nn_sequence_reshape
api_static_nn_reverse修改为api_paddle_static_nn_sequence_reverse
api_static_nn_sequence_pad修改为api_paddle_static_nn_sequence_pad
api_static_nn_softmax 修改为api_paddle_static_nn_sequence_softmax
api_static_static_sequence_unpad修改为api_paddle_static_nn_sequence_unpad
api_tensor_flatten修改为api_paddle_Tensor_flatten_
api_tensor_put_along_axis修改为api_paddle_Tensor_put_along_axis_
api_tensor_uniform修改为api_paddle_Tensor_uniform_
#57363
@ooooo-create @sunzhongkai588

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 21, 2023
@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@Sekiro-x Sekiro-x changed the title New branch [Docathon] Fix NO.6 API Label Sep 21, 2023
@Sekiro-x Sekiro-x changed the title [Docathon] Fix NO.6 API Label [Docathon] Fix NO.51-64 API Label Sep 21, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 21, 2023
python/paddle/nn/functional/pooling.py Outdated Show resolved Hide resolved
python/paddle/static/nn/sequence_lod.py Outdated Show resolved Hide resolved
python/paddle/static/nn/sequence_lod.py Outdated Show resolved Hide resolved
python/paddle/static/nn/sequence_lod.py Outdated Show resolved Hide resolved
python/paddle/tensor/manipulation.py Outdated Show resolved Hide resolved
python/paddle/tensor/manipulation.py Outdated Show resolved Hide resolved
python/paddle/tensor/random.py Outdated Show resolved Hide resolved
@@ -254,7 +254,7 @@ def sequence_pool(input, pool_type, is_test=False, pad_value=0.0):
r"""

Note:
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_static_nn_pool2d` ).
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_pool` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 这个需要和中文这样不?我感觉需要,因为确实两个都是
屏幕截图 2023-09-21 230948

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 这个需要和中文这样不?我感觉需要,因为确实两个都是
屏幕截图 2023-09-21 230948

改成引用这两个 API 叭

@@ -1420,7 +1420,7 @@ def sequence_mask(x, maxlen=None, dtype='int64', name=None):
def sequence_reverse(x, name=None):
"""
Note:
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_static_nn_reverse` ).
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_reverse` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 这个reverse我不是很清楚是否存在 reverse Op(这个ref),在api官网文档里搜索 reverse 没有搜索到

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

屏幕截图 2023-09-21 233450
@sunzhongkai588 多个 api 的 NOTE 都出现 static.nn.** 的情况,其中 static.nn 好像没有意义,是否要删除呢?

可能已经替换成 flip了,reverse API 调用的op好像就是 flip@zoooo0820 麻烦确认下~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成引用 paddle.flip

@ooooo-create
Copy link
Contributor

ooooo-create commented Sep 21, 2023

屏幕截图 2023-09-21 233450
@sunzhongkai588 多个 api 的 NOTE 都出现 static.nn.** 的情况,其中 static.nn 好像没有意义,是否要删除呢?

Sekiro-x and others added 7 commits September 22, 2023 09:34
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
@@ -1420,7 +1420,7 @@ def sequence_mask(x, maxlen=None, dtype='int64', name=None):
def sequence_reverse(x, name=None):
"""
Note:
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_static_nn_reverse` ).
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_reverse` ).
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

屏幕截图 2023-09-21 233450
@sunzhongkai588 多个 api 的 NOTE 都出现 static.nn.** 的情况,其中 static.nn 好像没有意义,是否要删除呢?

可能已经替换成 flip了,reverse API 调用的op好像就是 flip@zoooo0820 麻烦确认下~

python/paddle/static/nn/sequence_lod.py Show resolved Hide resolved
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sekiro-x 修改这两处即可

@@ -1420,7 +1420,7 @@ def sequence_mask(x, maxlen=None, dtype='int64', name=None):
def sequence_reverse(x, name=None):
"""
Note:
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_static_nn_reverse` ).
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_reverse` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成引用 paddle.flip

@@ -254,7 +254,7 @@ def sequence_pool(input, pool_type, is_test=False, pad_value=0.0):
r"""

Note:
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_static_nn_pool2d` ).
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_pool` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 这个需要和中文这样不?我感觉需要,因为确实两个都是
屏幕截图 2023-09-21 230948

改成引用这两个 API 叭

@Sekiro-x
Copy link
Contributor Author

@Sekiro-x 修改这两处即可

是把static_nn改为paddle.flip吗?引用两个API是做什么修改呢

Copy link
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是改这两个呢

@@ -1420,7 +1420,7 @@ def sequence_mask(x, maxlen=None, dtype='int64', name=None):
def sequence_reverse(x, name=None):
"""
Note:
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_static_nn_reverse` ).
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_reverse` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_reverse` ).
Only receives Tensor as input. If your input is Tensor, please use reverse Op.(static.nn.** :ref:`api_paddle_flip` ).

@@ -254,7 +254,7 @@ def sequence_pool(input, pool_type, is_test=False, pad_value=0.0):
r"""

Note:
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_static_nn_pool2d` ).
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_pool` ).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_paddle_static_nn_sequence_pool` ).
Only receives Tensor as input. If your input is Tensor, please use pool2d Op.(static.nn.** :ref:`api_paddle_nn_functional_avg_pool2d` or :ref:`api_paddle_nn_functional_max_pool2d` ).

@sunzhongkai588
Copy link
Contributor

已在 #57666 修复

@Sekiro-x Sekiro-x deleted the new_branch branch September 26, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants