Fix pool max with index.(Mask type should be int, not float) #5749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
fix_pool_with_index_op
branch
from
e189757 to
0e7874a
Compare
chengduoZH
force-pushed
the
fix_pool_with_index_op
branch
from
0e7874a to
5238c9f
Compare
kexinzhao
reviewed
Nov 17, 2017
| class TestCase7(TestMaxPoolWithIndex_Op): | ||
| def init_test_case(self): | ||
|
|
||
| class TestCase5(TestMaxPoolWithIndex_Op): |
Contributor
There was a problem hiding this comment.
Should it be TestCase5(TestCase4) ?
Contributor
Author
There was a problem hiding this comment.
Good catch. I have fixed it.
qingqing01
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5750