segment parallel parameter sync and grad sync #57061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
sneaxiy
reviewed
Sep 11, 2023
| and self._sep_degree == 1 | ||
| and self._sharding_degree > 1 | ||
| ): | ||
| # sharding may coexist with dp |
There was a problem hiding this comment.
如果sharding_degree > 1 and dp_degree > 1时，这个逻辑跟之前不太一样？
There was a problem hiding this comment.
嗯， 这个之前写的不优雅；
sharding > 1 and dp > 1 改成在 shardding_parallel里处理
| fleet_env.sharding_degree | ||
| == fleet_env._hcg.get_sharding_parallel_world_size() | ||
| ) | ||
| broadcast_sharding_parameters(model, fleet_env._hcg) |
There was a problem hiding this comment.
sharding > 1 and dp > 1 改成在 shardding_parallel里处理
FeixLiu
reviewed
Sep 11, 2023
python/paddle/distributed/fleet/meta_optimizers/dygraph_optimizer/hybrid_parallel_optimizer.py
Outdated
Show resolved
Hide resolved
… sep_grad_reduce
… sep_grad_reduce
… sep_grad_reduce
sneaxiy
approved these changes
Sep 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* sep grad all sync * polish * polish * polish * polish * add test * add test, and align with dp * follow comment * polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
paddle nlp llama 7b sep VS mp
