[3rd-party] update openBLAS to fix compile error on Raptor Lake #56617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiweibo 注意到注释中此前升级曾对IDG业务线有实际影响，能否帮忙确认新版本 |
risemeup1
reviewed
Aug 25, 2023
改好了 |
risemeup1
reviewed
Aug 30, 2023
| # OpenBLAS support Raptor Lake from v0.3.22 | ||
| if(UNIX | ||
| AND NOT APPLE | ||
| AND NOT WITH_ROCM |
yuanlehome
reviewed
Aug 30, 2023
| # OpenBLAS support Raptor Lake from v0.3.22 | ||
| if(UNIX | ||
| AND NOT APPLE | ||
| AND NOT WITH_ROCM |
There was a problem hiding this comment.
先确定下在这几个环境下 v0.3.22 能否正常编译，根据情况再添加上吧
There was a problem hiding this comment.
PR可以稍后合入哈@risemeup1，我们先验证下新版本下公司内部业务有没有问题～
There was a problem hiding this comment.
条件有限，我先用CI测一下 #56806
yuanlehome
approved these changes
Sep 1, 2023
|
hello, @jinyouzhi @risemeup1 我在本地Raptor Lake （Core i9 13900KF 上）机器上编译会报错。 编译选项 cmake .. -DWITH_GPU=OFF -DWITH_MKLDNN=OFF -DWITH_MKL=OFF编译器 |
刚刚在一台 Core i7 13700 上可以编译成功，编译器gcc 11.4，你可以检查一下你的目录Paddle/third-party/openblas以及Paddle/build/third-party/openblas 里面是指定版本吗？ |
|
@jinyouzhi 我这边 gcc 8.2 不行 |
我再尝试复现一下吧 |
|
@GreatV 我能复现了，thanks |
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…lePaddle#56617) * [3rd-party] update openBLAS to fix compile error on Raptor Lake * modify comments and remove the gcc version limit * switch third-party/openblas to v0.3.23 * fix
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
…ke (PaddlePaddle#56617)" (PaddlePaddle#58090) This reverts commit 15728a7.
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…ke (PaddlePaddle#56617)" (PaddlePaddle#58090) This reverts commit 15728a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
https://github.com/xianyi/OpenBLAS/blob/394a9fbafe9010b76a2615c562204277a956eb52/Changelog.txt#L54
https://github.com/xianyi/OpenBLAS/blob/394a9fbafe9010b76a2615c562204277a956eb52/Changelog.txt#L17
OpenBLAS 0.3.22 开始支持Raptor Lake，当前 0.3.18 版本不能在 Xeon 4th CPU上编译（当
WITH_MKL=OFF时）。