Skip to content

Conversation

@BiynXu
Copy link
Contributor

@BiynXu BiynXu commented Aug 9, 2023

PR types

New features

PR changes

Others

Description

Pcard-74043
Added a graph data structure in units of ScheduleBlock and some necessary operations, such as finding upstream and downstream nodes, and performing operations in the DFS topological order.

@paddle-bot
Copy link

paddle-bot bot commented Aug 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

}

bool IsReduceInitTensorName(const std::string &tensor_name) {
return tensor_name.length() > 13 &&
Copy link
Contributor

@ZzSean ZzSean Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个13会不会有点抽象了,要不定一个常量,名字叫length_of_xxx一类的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改,为"__reduce_init"后缀创建了常量

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit da72707 into PaddlePaddle:develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants