Skip to content

Conversation

@cqulilujia
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Description

Fix bugs in xpu kernel of rnn op.


int gate_num = 4;
int hidden_data_idx = (num_layers - 1);
hidden_data_idx += (gate_num + 1) * num_layers;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参照paddle/phi/kernels/cpu/rnn_functor.h 22行

@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2023
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@QingshuChen QingshuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen QingshuChen merged commit 0cd422b into PaddlePaddle:develop Jul 25, 2023
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
Wang-1F pushed a commit to Wang-1F/Paddle that referenced this pull request Aug 30, 2023
@cqulilujia cqulilujia changed the title fix bugs in rnn op [XPU] fix bugs in rnn op Sep 4, 2024
@cqulilujia cqulilujia deleted the fixrnn branch August 28, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants