Skip to content

Conversation

@BiynXu
Copy link
Contributor

@BiynXu BiynXu commented Jun 29, 2023

PR types

Others

PR changes

Others

Description

Pcard-72511
This pr comb the code of op lowering.
Organize the generalized Lower process into four stages:

  1. Call Compute and perform narrow Lower (i.e. translate graph to CINN IR).
  2. Do Op level schedule.
  3. Do group level schedule.
  4. Post process, including processing of LoweredFunc arguments and temporary variables, application of low level pass, etc

Then, all types of group lower processes call these processes, abstracting only a small amount of different logic and using different callback functions for processing, to achieve the maximum uniformity of the generalized Lower process.
Specifically, due to significant differences in the Lower logic of CustomCall, it needs to be handled separately by LowerCustomCall().

@paddle-bot
Copy link

paddle-bot bot commented Jun 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesLim-sy JamesLim-sy merged commit 3559252 into PaddlePaddle:develop Jul 13, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* [CINN] comb the op lowering code

* [CINN] format code of OpLower
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* [CINN] comb the op lowering code

* [CINN] format code of OpLower
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants