Skip to content

Conversation

@XiaociZhang
Copy link
Contributor

PR types

New features

PR changes

Others

Description

Add XPTI (XPU Profiling Tool Interface) to support XPU runtime profiling.

@paddle-bot
Copy link

paddle-bot bot commented Jun 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 15, 2023
chenwhql
chenwhql previously approved these changes Jun 15, 2023
Copy link
Contributor

@ykkk2333 ykkk2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RuohengMa RuohengMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

${XPU_XFT_GET_DEPENCE_URL} && bash get_xft_dependence.sh ${XPU_XFT_URL}
${XPU_XFT_DIR_NAME}
${XPU_XFT_DIR_NAME} && wget ${XPU_XPTI_GET_DEPENCE_URL} && bash
get_xpti_dependence.sh ${XPU_XPTI_URL} ${XPU_XPTI_DIR_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该像bkcl一样,单独搞出来一个判断吧?在WITH_XPU_XPTI的时候才需要用到这个dependence.sh以及下载依赖

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

忽略这条,现在bkcl也是默认下载的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是改成有条件下载,因为目前这个脚本需要替换libxpurt.so
等后面XRE的klprof合入主线后再考虑是否改成默认下载
#54711

@houj04 houj04 merged commit 82eeda6 into PaddlePaddle:develop Jun 16, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jun 16, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants