Skip to content

Conversation

kavyasrinet
Copy link

@kavyasrinet kavyasrinet commented Nov 4, 2017

  • Seq_concat
  • Seq_expand
  • Sequence_conv
  • Sequence_pool
  • Sequence_softmax
  • Sigmoid_cross_entropy_with_logits

.SetDefault(0);
AddComment(R"DOC(
Sequence Concat operator
Sequence Concat operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to "Sequence Concat Operator"? We now follows a all-cap format for operator title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the update.

Copy link
Contributor

@kexinzhao kexinzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangkuiyi wangkuiyi merged commit 2ac5d7d into PaddlePaddle:develop Nov 5, 2017
@kavyasrinet kavyasrinet deleted the op_doc branch November 6, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants