Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up WITH_MLU #52546

Merged
merged 8 commits into from
Apr 7, 2023
Merged

clean up WITH_MLU #52546

merged 8 commits into from
Apr 7, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Apr 5, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

clean up WITH_MLU.

@paddle-bot
Copy link

paddle-bot bot commented Apr 5, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 5, 2023
@GreatV GreatV mentioned this pull request Apr 5, 2023
Closed
ronny1996
ronny1996 previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage 流水线中 test_group 单测必挂，可以先revert test_group的修改么？

@GreatV
Copy link
Contributor Author

GreatV commented Apr 6, 2023

Coverage 流水线中 test_group 单测必挂，可以先revert test_group的修改么？

好的

@GreatV GreatV requested review from luotao1 and ronny1996 April 7, 2023 00:27
ronny1996
ronny1996 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit e75c01f into PaddlePaddle:develop Apr 7, 2023
@luotao1
Copy link
Contributor

luotao1 commented Apr 7, 2023

paddle/phi/backends/context_pool.cc 里面还有一处
image

@GreatV
Copy link
Contributor Author

GreatV commented Apr 7, 2023

paddle/phi/backends/context_pool.cc 里面还有一处 image

是的，还有一些字符串没有清理

@GreatV GreatV deleted the clean_up_WITH_MLU branch April 28, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronny1996 ronny1996 ronny1996 approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

Assignees

@luotao1 luotao1

@qili93 qili93

@ronny1996 ronny1996

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GreatV @luotao1 @ronny1996 @qili93