Skip to content

Rewrite StaticRNN with Executor #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Nov 2, 2017
Merged

Rewrite StaticRNN with Executor #5224

merged 47 commits into from
Nov 2, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 30, 2017

No description provided.

reyoung and others added 24 commits October 28, 2017 21:25
@reyoung
Init commit
e1d22b0
@reyoung
Make executor use ProgramDescBind
c35f956
@reyoung
Change Attribute from BlockDesc to BlockDescBind
aaf9173 
* Since we will get the program desc in RNN, just BlockDesc is not
  enough.
@reyoung
Add DeviceContext to Executor API
76575d1
@reyoung
Rewrite RNN
c65528f
@reyoung
Merge branch 'develop' into feature/rnn_use_executor
9197a26
@reyoung
Pass Python
61fa04d
@reyoung
AddBiasOp does not care num_flatten_dims
4b3a3ab
@reyoung
Merge branch 'feature/error_in_add_bias' into feature/rnn_use_executor
711da5a
@reyoung
Merge branch 'develop' of github.com:baidu/Paddle into feature/rnn_us…
1e2954c 
…e_executor
@reyoung
Stash
705329b
@reyoung
Fix MacOS Compile
4aca6c2
@reyoung
Merge branch 'feature/fill_compile' into feature/rnn_use_executor
cccc17c
@reyoung
Pass RNN forward
20bdfe2
add python test
425f283
refactor test
28090cf
@reyoung
Make compile pass
7610c30
Merge remote-tracking branch 'pr/5224' into 5224
de7738e
add gradopmaker
f207187
@reyoung
First draft done
1aafbe6
@reyoung
Polish code
d39534f
add grad op maker and grad infershape
4f72621
@reyoung
Polish code
0e757f5
@reyoung
Merge remote-tracking branch 'tony/add_rnn_test' into feature/rnn_use…
afcf54d 
…_executor
@reyoung reyoung force-pushed the feature/rnn_use_executor branch 2 times, most recently from 88b0519 to 3457931 Compare October 30, 2017 23:39
@reyoung reyoung changed the title StaticRNN with forward Rewrite StaticRNN with Executor Oct 31, 2017
Superjomn
Superjomn previously approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tonyyang-svail
tonyyang-svail approved these changes Nov 2, 2017
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides lack of reverse order test, looks good to me.

This was referenced Nov 2, 2017
Closed
Closed
@reyoung reyoung merged commit 0a32e74 into PaddlePaddle:develop Nov 2, 2017
@tonyyang-svail tonyyang-svail mentioned this pull request Nov 27, 2017
Closed
@reyoung reyoung deleted the feature/rnn_use_executor branch December 26, 2017 09:35
@typhoonzero typhoonzero mentioned this pull request May 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

+1 more reviewer

@Superjomn Superjomn Superjomn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reyoung @Superjomn @tonyyang-svail