Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove parallel_executor related unit tests #51632

Merged
merged 2 commits into from
Mar 15, 2023
Merged

remove parallel_executor related unit tests #51632

merged 2 commits into from
Mar 15, 2023

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Mar 14, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

ParallelExecutor is not maintained now, we're removing its code recently. These two unit tests is used to test the function of PE only, so they can be deleted.

Others

Pcard-67004

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhiqiu
zhiqiu approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测删除

zhwesky2010
zhwesky2010 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for rm parallel_UT

@kangguangli kangguangli merged commit 892f94b into PaddlePaddle:develop Mar 15, 2023
@kangguangli kangguangli deleted the rm_parallel_executor_unittests branch March 15, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangguangli @zhiqiu @XieYunshen @zhwesky2010