Skip to content

Fix new remote updater sending all 0 param / grad to pserver #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fix new remote updater sending all 0 param / grad to pserver #5095

merged 1 commit into from
Oct 25, 2017

Conversation

helinwang
Copy link
Contributor

@helinwang helinwang commented Oct 25, 2017 •
edited
Loading

The trainer initializes the pserver with all 0 parameters, this fix address it.

jacquesqiao
jacquesqiao approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add some description about the problem that this PR try to fix.

@helinwang helinwang merged commit 629cbda into PaddlePaddle:develop Oct 25, 2017
@helinwang helinwang deleted the zero branch October 25, 2017 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helinwang @jacquesqiao