add sparse support for sum op #5093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 26, 2017
paddle/framework/executor.cc
Outdated
| } | ||
| } | ||
|
|
||
| void CreateTensor(Variable* var, VarDesc::VarType var_type) { |
There was a problem hiding this comment.
static void CreateTensor()
reyoung
reviewed
Oct 26, 2017
paddle/framework/selected_rows.h
Outdated
|
|
||
| const Vector<int64_t>& rows() const { return rows_; } | ||
|
|
||
| Vector<int64_t>& mutable_rows() { return rows_; } |
There was a problem hiding this comment.
Vector<int64_t>* mutable_rows()
reyoung
reviewed
Oct 26, 2017
| } | ||
| }; | ||
|
|
||
| template struct SelectedRowsAddTo<platform::CPUPlace, float>; |
reyoung
reviewed
Oct 26, 2017
| out->Resize(in_vars[i]->Get<framework::LoDTensor>().dims()); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
39-44 lines are not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5094
This PR depends on #5027
Because current operator backward tests are still based on run-time, not compile-time, we can not set correct Variable type in backward process.
I comment check_grad of test_sum_op for an example. test_word2vec and test_sum_op can pass ci test.