Skip to content

fix var_type_inference_test #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2017
Merged

fix var_type_inference_test #4854

merged 1 commit into from
Oct 17, 2017

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Oct 17, 2017 •
edited
Loading

merge conflict

@jacquesqiao jacquesqiao requested review from QiJune and reyoung October 17, 2017 01:09
Superjomn
Superjomn approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacquesqiao jacquesqiao merged commit fafc54d into PaddlePaddle:develop Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@QiJune QiJune Awaiting requested review from QiJune

+1 more reviewer

@Superjomn Superjomn Superjomn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacquesqiao @Superjomn @JiayiFeng