Skip to content

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 15, 2017

Follow PEP8

@reyoung reyoung requested review from QiJune and jacquesqiao October 15, 2017 00:08
@QiJune
Copy link
Member

QiJune commented Oct 15, 2017

Please refer to https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/name_convention.md.

Attribute name follows the camelCase

Maybe we have to unify the name convention.

wangkuiyi
wangkuiyi previously approved these changes Oct 16, 2017
@wangkuiyi
Copy link
Collaborator

Sorry that I approved by mistake -- I read @QiJune 's comment after the approval. Please follow @QiJune 's comment instead of mine.

@reyoung reyoung changed the title Change dataType to data_type Change Name convention of operator attributes Oct 16, 2017
@reyoung reyoung force-pushed the feature/unify_data_type branch from 79bed0d to 8e6522a Compare October 16, 2017 20:57
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 75d0c79 into PaddlePaddle:develop Oct 16, 2017
@reyoung reyoung deleted the feature/unify_data_type branch October 28, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants