Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][F403] expand star import #46946

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Oct 12, 2022

PR types

Others

PR changes

Others

Describe

利用 autoflake 展开 from xxx import *,部分无法展开的通过手动展开 / 直接加 # noqa: F403 ignore 掉

Related links

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 12, 2022
@SigureMo SigureMo changed the title [CodeStyle][F403] expand star import [WIP][CodeStyle][F403] expand star import Oct 12, 2022
@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@SigureMo SigureMo changed the title [WIP][CodeStyle][F403] expand star import [CodeStyle][F403] expand star import Oct 12, 2022
@luotao1 luotao1 self-assigned this Oct 13, 2022
luotao1
luotao1 previously approved these changes Oct 13, 2022
XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 19, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Oct 19, 2022

请解决下冲突

@SigureMo SigureMo dismissed stale reviews from XiaoguangHu01 and luotao1 via dd59e21 October 19, 2022 04:58
@SigureMo
Copy link
Member Author

请解决下冲突

已解决~

@luotao1 luotao1 merged commit 499d2da into PaddlePaddle:develop Oct 19, 2022
@SigureMo SigureMo deleted the F403/fix branch October 19, 2022 07:36
SigureMo added a commit to ccsuzzh/Paddle that referenced this pull request Sep 30, 2023
luotao1 pushed a commit that referenced this pull request Oct 9, 2023
…`(part3) (#57839)

* enable isort in python/paddle/base/framework.py

* try relative import

* `fluid_version` -> `paddle_version`

* correct noqa: F401

* try to fix import order deps

* refine comments

* `ir_change` -> `ir_guard`

* fix some ugly import from #46946

* fix `paddle/base/__init__.py`

* move all patch code into one place

* move all patch code to base/__init__.py

* remove monkey_patch_math_tensor, its part of monkey_patch_tensor

* adjust patch order

* Revert "adjust patch order"

This reverts commit 11a4881.

* Revert "remove monkey_patch_math_tensor, its part of monkey_patch_tensor"

This reverts commit 9532b66.

* Revert "move all patch code to base/__init__.py"

This reverts commit 3b1894c.

* Revert "move all patch code into one place"

This reverts commit 574d9ca.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
…`(part3) (PaddlePaddle#57839)

* enable isort in python/paddle/base/framework.py

* try relative import

* `fluid_version` -> `paddle_version`

* correct noqa: F401

* try to fix import order deps

* refine comments

* `ir_change` -> `ir_guard`

* fix some ugly import from PaddlePaddle#46946

* fix `paddle/base/__init__.py`

* move all patch code into one place

* move all patch code to base/__init__.py

* remove monkey_patch_math_tensor, its part of monkey_patch_tensor

* adjust patch order

* Revert "adjust patch order"

This reverts commit 11a4881.

* Revert "remove monkey_patch_math_tensor, its part of monkey_patch_tensor"

This reverts commit 9532b66.

* Revert "move all patch code to base/__init__.py"

This reverts commit 3b1894c.

* Revert "move all patch code into one place"

This reverts commit 574d9ca.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
…`(part3) (PaddlePaddle#57839)

* enable isort in python/paddle/base/framework.py

* try relative import

* `fluid_version` -> `paddle_version`

* correct noqa: F401

* try to fix import order deps

* refine comments

* `ir_change` -> `ir_guard`

* fix some ugly import from PaddlePaddle#46946

* fix `paddle/base/__init__.py`

* move all patch code into one place

* move all patch code to base/__init__.py

* remove monkey_patch_math_tensor, its part of monkey_patch_tensor

* adjust patch order

* Revert "adjust patch order"

This reverts commit 11a4881.

* Revert "remove monkey_patch_math_tensor, its part of monkey_patch_tensor"

This reverts commit 9532b66.

* Revert "move all patch code to base/__init__.py"

This reverts commit 3b1894c.

* Revert "move all patch code into one place"

This reverts commit 574d9ca.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…`(part3) (PaddlePaddle#57839)

* enable isort in python/paddle/base/framework.py

* try relative import

* `fluid_version` -> `paddle_version`

* correct noqa: F401

* try to fix import order deps

* refine comments

* `ir_change` -> `ir_guard`

* fix some ugly import from PaddlePaddle#46946

* fix `paddle/base/__init__.py`

* move all patch code into one place

* move all patch code to base/__init__.py

* remove monkey_patch_math_tensor, its part of monkey_patch_tensor

* adjust patch order

* Revert "adjust patch order"

This reverts commit 11a4881.

* Revert "remove monkey_patch_math_tensor, its part of monkey_patch_tensor"

This reverts commit 9532b66.

* Revert "move all patch code to base/__init__.py"

This reverts commit 3b1894c.

* Revert "move all patch code into one place"

This reverts commit 574d9ca.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[F403] ‘from module import *’ used; unable to detect undefined names
3 participants