Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] migrate compare op(E/NE/LE/LT/GE/GT) from fluid to phi #45470

Merged
merged 8 commits into from
Aug 31, 2022

Conversation

kangguangli
Copy link
Contributor

PR types

Others

PR changes

OPs

Describe

migrate compare op from fluid to phi, including:

  1. equal
  2. not_equal
  3. less_than
  4. less_equal
  5. greater_than
  6. greater_equal

errors::External(
"XPU kernel compare op occur error[%d %s] in XPUCompare.",
ret,
XPUAPIErrorMsg[ret]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以使用PADDLE_ENFORCE_XDNN_SUCCESS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

YuanRisheng
YuanRisheng previously approved these changes Aug 31, 2022
Copy link
Contributor

@ykkk2333 ykkk2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 12d9cfc into PaddlePaddle:develop Aug 31, 2022
@kangguangli kangguangli deleted the xpu_compare_op branch August 31, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants