add del dropout op pass to jit pe enigne #45439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Aug 31, 2022
Aurelius84
reviewed
Aug 31, 2022
| @@ -74,6 +74,8 @@ PEEngine::PEEngine(const std::shared_ptr<FunctionInfo> &info, | |||
|
|
|||
| void PEEngine::CreateGraphAndPE() { | |||
| framework::details::BuildStrategy build_strategy; | |||
| build_strategy.inference_ = true; | |||
| build_strategy.del_dropout_ = true; | |||
There was a problem hiding this comment.
这里只需要build_strategy.inference_ = true 即可。
这里这样写会影响扩展性，因为JitLayer并没有假设「仅支持Inference」，如果后续JitLayer承担更多角色时，但又不需要对用户暴露额外的头文件概念（如 build_strategy），这里看起属于类似 hard code的写法。
There was a problem hiding this comment.
后面的PR会提一个可配的选项，可以在那个PR再讨论下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe