[API]Support static branch in paddle.to_tensor #45164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
feifei-111
changed the title
Aurelius84
reviewed
Aug 18, 2022
| place = _get_paddle_place(place) | ||
| if place is None: | ||
| place = _current_expected_place() | ||
| elif not isinstance( |
There was a problem hiding this comment.
这个判断其实可以去掉，_get_paddle_place里已经有合法性检查了。可以复用_to_tensor_non_static
| "'place' must be any of paddle.Place, paddle.CPUPlace, paddle.CUDAPinnedPlace, paddle.CUDAPlace, paddle.NPUPlace, paddle.XPUPlace, paddle.MLUPlace, paddle.CustomPlace" | ||
| ) | ||
|
|
||
| import re |
There was a problem hiding this comment.
不要动态import， import语句放到文件最前面
| def call_assign(data, dtype=None, stop_grandient=None): | ||
|
|
||
| if isinstance(data, | ||
| (Variable, core.VarBase)) and (dtype is None or dtype |
There was a problem hiding this comment.
这里只需要判断Variable就可以了吧，这个是静态图分支，如果出现core.VarBase应该是非法的吧？
| if dtype: | ||
| target_dtype = convert_dtype(dtype) | ||
| elif hasattr(data, 'dtype'): | ||
| target_dtype = convert_dtype(data.dtype) |
There was a problem hiding this comment.
if hasattr(data, 'dtype'):
dtype = data.dtype
elif dtype is None:
dtype = paddle.get_default_dtype()
target_dtype = convert_dtype(dtype)| else: | ||
| place = paddle.CPUPlace() | ||
|
|
||
| x = paddle.to_tensor(paddle.randn([5, 2]), |
There was a problem hiding this comment.
单测需要再丰富一下，你这里并没有测试[var, 1, 1]的情况
Aurelius84
reviewed
Aug 18, 2022
| @@ -12,6 +12,8 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| # to_tensor api will create 1 less op now, this test was changed | |||
Aurelius84
reviewed
Aug 18, 2022
| # call assign for static graph | ||
| else: | ||
|
|
||
| def call_assign(data, dtype=None, stop_grandient=None): |
There was a problem hiding this comment.
_to_tensor_static() 放到外面
Aurelius84
reviewed
Aug 18, 2022
| ) | ||
|
|
||
| import re | ||
| re_exp = re.compile(r'[(](.*?)[)]', re.S) |
There was a problem hiding this comment.
Suggested change
| re_exp = re.compile(r'[(](.*?)[)]', re.S) | |
| re_exp = re.compile(r'[(](.*+)[)]', re.S) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe