Skip to content

[LAUNCH] fix set args bug #44717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

[LAUNCH] fix set args bug #44717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6015e57
fix set args bug
kuizhiqing Jul 29, 2022
66df545
dist test to run_check
kuizhiqing Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/paddle/distributed/launch/context/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ def continous_log(self) -> bool:
return False

def set_env_in_args(self):
# this logic may not propre to replace args with env, but ...
for k, v in env_args_mapping.items():
if k in self.envs:
setattr(self.args, v, type(getattr(self.args, v))(self.envs[k]))
setattr(self.args, v, self.envs[k])
3 changes: 2 additions & 1 deletion python/paddle/distributed/launch/controllers/collective.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def register(self):

def run(self):

timeout = self.ctx.args.elastic_timeout if self.job.elastic else self.ctx.args.elastic_timeout * 10
timeout = int(self.ctx.args.elastic_timeout)
timeout = timeout if self.job.elastic else timeout * 10
self.register()

while self.pod.restart <= self.ctx.args.max_restart:
Expand Down
2 changes: 1 addition & 1 deletion python/paddle/distributed/launch/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def rewrite_host_ip(ctx):


def test_mode(ctx):
if ctx.args.training_script == 'test':
if ctx.args.training_script == 'run_check':
ctx.logger.info('Paddle Distributed Test begin...')
if int(ctx.args.nnodes) < 2:
ctx.args.nnodes = 2
Expand Down